Bug report: /gemlog does not redirect to /gemlog/

Hello! I noticed this bug when a gemsub feed was submitted to Antenna without the trailing slash. In detail: When calling gemini://<DOMAIN>/gemlog the response is "20 text/gemini; charset=UTF-8" followed by the body of gemini://<DOMAIN>/gemlog/index.gmi The result is that all relative links are resolved wrongly. A link like "=> post-123.gmi" will lead to gemini://<DOMAIN>/post-123.gmi rather than the intended gemini://<DOMAIN>/gemlog/post-123.gmi The correct response for a call to gemini://<DOMAIN>/gemlog would be "31 gemini://<DOMAIN>/gemlog/" I believe the bug originates here: https://git.alexwennerberg.com/flounder/file/gemini.go.html#l100 ``` 100 if fileName == "/gemlog" { // temp hack 101 _, err := os.Stat(path.Join(fullPath, "index.gmi")) 102 if err != nil { 103 w.WriteHeader(gmi.StatusSuccess, "text/gemini") 104 io.Copy(w, strings.NewReader(generateGemfeedPage(userName))) 105 return 106 } ``` I'm not familiar enough with Go to quickly solve it. Cheers, ew0k

Hi Bjorn, I actually discovered this bug recently as well. I am on vacation and probably won’t be able to resolve it until I get back, but will definitely get it fixed when I can! Alex > On Apr 13, 2022, at 10:18 PM, Björn Wärmedal <bjorn.warmedal@gmail.com> wrote: > > Hello! > > I noticed this bug when a gemsub feed was submitted to Antenna without > the trailing slash. > > In detail: > When calling gemini://<DOMAIN>/gemlog the response is "20 text/gemini; > charset=UTF-8" followed by the body of > gemini://<DOMAIN>/gemlog/index.gmi > > The result is that all relative links are resolved wrongly. A link > like "=> post-123.gmi" will lead to gemini://<DOMAIN>/post-123.gmi > rather than the intended gemini://<DOMAIN>/gemlog/post-123.gmi > > The correct response for a call to gemini://<DOMAIN>/gemlog would be > "31 gemini://<DOMAIN>/gemlog/" > > I believe the bug originates here: > https://git.alexwennerberg.com/flounder/file/gemini.go.html#l100 > > ``` > 100 if fileName == "/gemlog" { // temp hack > 101 _, err := os.Stat(path.Join(fullPath, "index.gmi")) > 102 if err != nil { > 103 w.WriteHeader(gmi.StatusSuccess, "text/gemini") > 104 io.Copy(w, strings.NewReader(generateGemfeedPage(userName))) > 105 return > 106 } > ``` > > I'm not familiar enough with Go to quickly solve it. > > Cheers, > ew0k

The slight challenge is distinguishing between a folder (which should redirect) and a text file with no extension (which shouldn’t) — I’ll figure something out Alex > On Apr 13, 2022, at 10:41 PM, Alex <alex@alexwennerberg.com> wrote: > > Hi Bjorn, I actually discovered this bug recently as well. I am on vacation and probably won’t be able to resolve it until I get back, but will definitely get it fixed when I can! > > Alex > >> On Apr 13, 2022, at 10:18 PM, Björn Wärmedal <bjorn.warmedal@gmail.com> wrote: >> >> Hello! >> >> I noticed this bug when a gemsub feed was submitted to Antenna without >> the trailing slash. >> >> In detail: >> When calling gemini://<DOMAIN>/gemlog the response is "20 text/gemini; >> charset=UTF-8" followed by the body of >> gemini://<DOMAIN>/gemlog/index.gmi >> >> The result is that all relative links are resolved wrongly. A link >> like "=> post-123.gmi" will lead to gemini://<DOMAIN>/post-123.gmi >> rather than the intended gemini://<DOMAIN>/gemlog/post-123.gmi >> >> The correct response for a call to gemini://<DOMAIN>/gemlog would be >> "31 gemini://<DOMAIN>/gemlog/" >> >> I believe the bug originates here: >> https://git.alexwennerberg.com/flounder/file/gemini.go.html#l100 >> >> ``` >> 100 if fileName == "/gemlog" { // temp hack >> 101 _, err := os.Stat(path.Join(fullPath, "index.gmi")) >> 102 if err != nil { >> 103 w.WriteHeader(gmi.StatusSuccess, "text/gemini") >> 104 io.Copy(w, strings.NewReader(generateGemfeedPage(userName))) >> 105 return >> 106 } >> ``` >> >> I'm not familiar enough with Go to quickly solve it. >> >> Cheers, >> ew0k